Skip to content

Add logging for each stage of the eiger arming#1468

Merged
DominicOram merged 5 commits intomainfrom
mx-bluesky-1204-log-eiger-arming
Sep 1, 2025
Merged

Add logging for each stage of the eiger arming#1468
DominicOram merged 5 commits intomainfrom
mx-bluesky-1204-log-eiger-arming

Conversation

@olliesilvester
Copy link
Contributor

Part of DiamondLightSource/mx-bluesky#1204

When the eiger fails to arm, we can't easily see exactly which part of the staging process failed, since we just see that the overall status failed. See https://graylog.diamond.ac.uk/messages/graylog-prod_7/66e85600-7912-11f0-9564-9635308342fa

This PR will give us slightly more info when the Eiger fails to arm

Instructions to reviewer on how to test:

  1. Check each stage of the arming now will give a logging message

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@olliesilvester olliesilvester requested a review from a team as a code owner August 20, 2025 13:51
@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.75%. Comparing base (2c9bbb7) to head (facf99a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1468   +/-   ##
=======================================
  Coverage   98.74%   98.75%           
=======================================
  Files         235      235           
  Lines        8626     8641   +15     
=======================================
+ Hits         8518     8533   +15     
  Misses        108      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment but generally looks good, thanks,

fake_eiger.arming_status.wait(1) # This should complete long before 1s
# One log message kicking off arming, then one for each of the 13 arming stages
assert len(caplog.messages) == 14
print(caplog)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Remove print statement in code

@DominicOram DominicOram merged commit 8bd1ce5 into main Sep 1, 2025
11 checks passed
@DominicOram DominicOram deleted the mx-bluesky-1204-log-eiger-arming branch September 1, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants