Add logging for each stage of the eiger arming#1468
Merged
DominicOram merged 5 commits intomainfrom Sep 1, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1468 +/- ##
=======================================
Coverage 98.74% 98.75%
=======================================
Files 235 235
Lines 8626 8641 +15
=======================================
+ Hits 8518 8533 +15
Misses 108 108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DominicOram
approved these changes
Aug 26, 2025
Contributor
DominicOram
left a comment
There was a problem hiding this comment.
Minor comment but generally looks good, thanks,
| fake_eiger.arming_status.wait(1) # This should complete long before 1s | ||
| # One log message kicking off arming, then one for each of the 13 arming stages | ||
| assert len(caplog.messages) == 14 | ||
| print(caplog) |
Contributor
There was a problem hiding this comment.
Nit: Remove print statement in code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of DiamondLightSource/mx-bluesky#1204
When the eiger fails to arm, we can't easily see exactly which part of the staging process failed, since we just see that the overall status failed. See https://graylog.diamond.ac.uk/messages/graylog-prod_7/66e85600-7912-11f0-9564-9635308342fa
This PR will give us slightly more info when the Eiger fails to arm
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}