Skip to content

Add path provider to dodal connect#1478

Merged
callumforrester merged 1 commit intomainfrom
fake-path-provider-cli
Aug 26, 2025
Merged

Add path provider to dodal connect#1478
callumforrester merged 1 commit intomainfrom
fake-path-provider-cli

Conversation

@callumforrester
Copy link
Contributor

Temporary solution to #1129, should not close, but at least makes sure that dodal connect is not broken for beamlines using numtracker.

Instructions to reviewer on how to test:

  1. Run dodal connect b01_1

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@callumforrester callumforrester requested a review from a team as a code owner August 22, 2025 12:11
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.73%. Comparing base (8386a84) to head (f0e00e1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1478   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         232      232           
  Lines        8588     8593    +5     
=======================================
+ Hits         8479     8484    +5     
  Misses        109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@callumforrester callumforrester merged commit ef17662 into main Aug 26, 2025
19 of 20 checks passed
@callumforrester callumforrester deleted the fake-path-provider-cli branch August 26, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants