Example device creation process and write tests docs#1484
Merged
oliwenmandiamond merged 24 commits intomainfrom Sep 3, 2025
Merged
Example device creation process and write tests docs#1484oliwenmandiamond merged 24 commits intomainfrom
oliwenmandiamond merged 24 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 235 235
Lines 8645 8645
=======================================
Hits 8537 8537
Misses 108 108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I have updated the docs on how to test your enums match epics and what you need to know when writing tests on devices in dodal. I am not sure my example is the best, so if you're able to suggest a better example for me to use that would be great! Thanks |
noemifrisina
approved these changes
Aug 28, 2025
Collaborator
noemifrisina
left a comment
There was a problem hiding this comment.
Just a couple of comments, it's good overall, just a bit clunky in a couple of places.
Example is nice, I don't think we need anything else to give a good idea what to do.
…vice-apis-and-testing' into example_device_creation_process
Base automatically changed from
1382-improve-documentation-on-device-apis-and-testing
to
main
August 29, 2025 10:55
Co-authored-by: Joseph Ware <53935796+DiamondJoseph@users.noreply.github.com>
DiamondJoseph
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #634
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}