I19 optics: pass an instrument session to the optics hutch devices#1493
Merged
noemifrisina merged 3 commits intomainfrom Sep 2, 2025
Merged
I19 optics: pass an instrument session to the optics hutch devices#1493noemifrisina merged 3 commits intomainfrom
noemifrisina merged 3 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1493 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 235 235
Lines 8641 8642 +1
=======================================
+ Hits 8533 8534 +1
Misses 108 108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DiamondJoseph
approved these changes
Sep 2, 2025
olliesilvester
approved these changes
Sep 2, 2025
| self, | ||
| prefix: str, | ||
| hutch: HutchState, | ||
| instrument_session: str = "", |
Contributor
There was a problem hiding this comment.
Can you link to DiamondLightSource/blueapi#1187 in comments here?
Collaborator
Author
There was a problem hiding this comment.
Good point, yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See blueapi#1187
As of blueapi 1.0.0 the
instrument_sessionis a required field in the REST call for posting a plan. We don't yet have a way for propagating it to the optics hutch devices (see linked ticket), but for the moment it should be enough to pass the latest commissioning directory.Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}