Skip to content

I19 optics: pass an instrument session to the optics hutch devices#1493

Merged
noemifrisina merged 3 commits intomainfrom
i19-instrument-session-workaround
Sep 2, 2025
Merged

I19 optics: pass an instrument session to the optics hutch devices#1493
noemifrisina merged 3 commits intomainfrom
i19-instrument-session-workaround

Conversation

@noemifrisina
Copy link
Collaborator

@noemifrisina noemifrisina commented Sep 1, 2025

See blueapi#1187

As of blueapi 1.0.0 the instrument_session is a required field in the REST call for posting a plan. We don't yet have a way for propagating it to the optics hutch devices (see linked ticket), but for the moment it should be enough to pass the latest commissioning directory.

Instructions to reviewer on how to test:

  1. Run tests

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@noemifrisina noemifrisina changed the title Temporary worksound for instrument session I19 optics: pass an instrument session to the optics hutch Sep 1, 2025
@noemifrisina noemifrisina changed the title I19 optics: pass an instrument session to the optics hutch I19 optics: pass an instrument session to the optics hutch devices Sep 1, 2025
@noemifrisina noemifrisina marked this pull request as ready for review September 1, 2025 08:57
@noemifrisina noemifrisina requested a review from a team as a code owner September 1, 2025 08:57
@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.75%. Comparing base (411f853) to head (54fd745).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1493   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         235      235           
  Lines        8641     8642    +1     
=======================================
+ Hits         8533     8534    +1     
  Misses        108      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

self,
prefix: str,
hutch: HutchState,
instrument_session: str = "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link to DiamondLightSource/blueapi#1187 in comments here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, yes

@noemifrisina noemifrisina merged commit 72db5ad into main Sep 2, 2025
11 checks passed
@noemifrisina noemifrisina deleted the i19-instrument-session-workaround branch September 2, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants