Skip to content

1406 added lakeshore to each corresponding beamline#1805

Merged
Relm-Arrowny merged 6 commits intomainfrom
1406-added-lakeshore-to-each-corresponding-beamline
Jan 6, 2026
Merged

1406 added lakeshore to each corresponding beamline#1805
Relm-Arrowny merged 6 commits intomainfrom
1406-added-lakeshore-to-each-corresponding-beamline

Conversation

@Relm-Arrowny
Copy link
Contributor

@Relm-Arrowny Relm-Arrowny commented Jan 5, 2026

Fixes #1406

Instructions to reviewer on how to test:

  1. Check connections
  2. Confirm all connect

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Relm-Arrowny Relm-Arrowny linked an issue Jan 5, 2026 that may be closed by this pull request
6 tasks
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.12%. Comparing base (5955929) to head (5a54a47).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1805   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files         282      283    +1     
  Lines       10698    10736   +38     
=======================================
+ Hits        10604    10642   +38     
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Relm-Arrowny Relm-Arrowny marked this pull request as ready for review January 6, 2026 10:19
@Relm-Arrowny Relm-Arrowny requested a review from a team as a code owner January 6, 2026 10:19
Copy link
Contributor

@oliwenmandiamond oliwenmandiamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Relm-Arrowny Relm-Arrowny merged commit 00af332 into main Jan 6, 2026
11 checks passed
@Relm-Arrowny Relm-Arrowny deleted the 1406-added-lakeshore-to-each-corresponding-beamline branch January 6, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Added lakeshore to each corresponding beamline.

2 participants

Comments