Skip to content

make Apple2 max phase and gap limits configurable#1816

Merged
Villtord merged 3 commits intomainfrom
make_apple2_max_gap_phase_configurable
Jan 16, 2026
Merged

make Apple2 max phase and gap limits configurable#1816
Villtord merged 3 commits intomainfrom
make_apple2_max_gap_phase_configurable

Conversation

@Villtord
Copy link
Contributor

@Villtord Villtord commented Jan 14, 2026

Fixes #1817
Allows to configure max phase and gap limits in apple2 controller which is helpful for child classes.

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Villtord Villtord self-assigned this Jan 14, 2026
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.14%. Comparing base (11c03e6) to head (c9e2b5f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1816   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         289      289           
  Lines       10970    10972    +2     
=======================================
+ Hits        10876    10878    +2     
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Villtord Villtord marked this pull request as ready for review January 14, 2026 15:20
@Villtord Villtord requested a review from a team as a code owner January 14, 2026 15:20
@Villtord Villtord linked an issue Jan 14, 2026 that may be closed by this pull request
@Villtord Villtord requested a review from Relm-Arrowny January 15, 2026 17:13
Copy link
Contributor

@Relm-Arrowny Relm-Arrowny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very sensible, LGTM

@Villtord Villtord enabled auto-merge (squash) January 16, 2026 12:23
@Villtord Villtord merged commit 9f921c1 into main Jan 16, 2026
9 checks passed
@Villtord Villtord deleted the make_apple2_max_gap_phase_configurable branch January 16, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make max phase and gap limits in apple2 controller configurable

2 participants

Comments