ElectronAnalyser no longer depends directly on sequence file path to work with BlueAPI

[oliwenmandiamond]

Fixes #1924

Instructions to reviewer on how to test:

1. Check tests pass

Checks for reviewer

• Would the PR title make sense to a scientist on a set of release notes
• If a new device has been added does it follow the standards
• If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
• Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (ec5fc8d) to head (de1c820).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1923      +/-   ##
==========================================
- Coverage   99.05%   99.05%   -0.01%     
==========================================
  Files         312      312              
  Lines       11754    11735      -19     
==========================================
- Hits        11643    11624      -19     
  Misses        111      111              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Villtord]

this is a driver that is created and passed in a child class, here in parent class it is taken out from the controller and saved as a class object - wouldn't it be clearer to make it in a child class directly when driver is created?

[oliwenmandiamond]

The class is then in charge of making sure the driver and detector connect and parent/name relationship is correct rather than the API. It's much better to make sure the API does it as all classes will need to do this, otherwise we copy and paste this line x number times for number of implementations which is unnecessary.

[Villtord]

you probably won't need to copy paste anything just add "self.driver" instead of making internal "driver" in a child class

[oliwenmandiamond]

The issue with this is that if we type anything as using the GenericElectronAnalyser for tests or plans or other devices i.e it doesn't care about if it Specs, Mbs, VGScienta etc. then it loses access to the driver because it lives now on the implementation and not on the base. We need it to be done here.

[Villtord]

do you need this class here? it seems to be used only in tests

[oliwenmandiamond]

Yeah, this will be used in plan repo too.

[Villtord]

which plan repo? sm-bluesky?

[oliwenmandiamond]

yes

https://github.com/search?q=repo%3ADiamondLightSource%2Fsm-bluesky%20GenericElectronAnalyserDetector&type=code