Skip to content

Reflect new config server structure#1977

Merged
jacob720 merged 35 commits intomainfrom
mx_bluesky_1629_remove_mx_config_client
Mar 18, 2026
Merged

Reflect new config server structure#1977
jacob720 merged 35 commits intomainfrom
mx_bluesky_1629_remove_mx_config_client

Conversation

@jacob720
Copy link
Contributor

@jacob720 jacob720 commented Mar 12, 2026

Since DiamondLightSource/daq-config-server#165, the import paths for the daq-config-server has changed.

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@jacob720 jacob720 requested a review from a team as a code owner March 12, 2026 13:47
Base automatically changed from mx_bluesky_1504_migrate_beamline_parameters_to_config_server to main March 13, 2026 16:26
@jacob720 jacob720 force-pushed the mx_bluesky_1629_remove_mx_config_client branch from 3fa8e91 to ddbc009 Compare March 13, 2026 16:48
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.12%. Comparing base (8d14783) to head (db0f888).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1977   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files         319      319           
  Lines       12201    12201           
=======================================
  Hits        12094    12094           
  Misses        107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank goodness the ConfigServer is now correctly named!
Approved.

@oliwenmandiamond
Copy link
Contributor

We should do a new release of daq-config-server first and update dodal to point to that release before we merge

@jacob720 jacob720 enabled auto-merge (squash) March 18, 2026 09:43
@jacob720 jacob720 merged commit 7aebba2 into main Mar 18, 2026
9 checks passed
@jacob720 jacob720 deleted the mx_bluesky_1629_remove_mx_config_client branch March 18, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants