Merged
Conversation
1 task
Base automatically changed from
mx_bluesky_1504_migrate_beamline_parameters_to_config_server
to
main
March 13, 2026 16:26
3fa8e91 to
ddbc009
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1977 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 319 319
Lines 12201 12201
=======================================
Hits 12094 12094
Misses 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rtuck99
approved these changes
Mar 17, 2026
Contributor
rtuck99
left a comment
There was a problem hiding this comment.
Thank goodness the ConfigServer is now correctly named!
Approved.
Contributor
|
We should do a new release of daq-config-server first and update dodal to point to that release before we merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since DiamondLightSource/daq-config-server#165, the import paths for the daq-config-server has changed.
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}