Added second panda interface for P51 beamline#1986
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1986 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 318 318
Lines 12328 12331 +3
=======================================
+ Hits 12219 12222 +3
Misses 109 109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LuisFSegalla
approved these changes
Mar 23, 2026
Comment on lines
+66
to
70
| def panda1(path_provider: PathProvider) -> HDFPanda: | ||
| return HDFPanda( | ||
| f"{PREFIX.beamline_prefix}-EA-PANDA-02:", | ||
| path_provider=path_provider, | ||
| ) |
Contributor
There was a problem hiding this comment.
panda1 device but PV is panda 2, is this correct?
Contributor
Author
There was a problem hiding this comment.
Yes, we designed the scans in panda-02 first, and called it panda1. That might be changed later, but as the scans currently stand, this is intentional and correct.
Comment on lines
+74
to
+78
| def panda2(path_provider: PathProvider) -> HDFPanda: | ||
| return HDFPanda( | ||
| f"{PREFIX.beamline_prefix}-EA-PANDA-01:", | ||
| path_provider=path_provider, | ||
| ) |
Contributor
There was a problem hiding this comment.
panda2 device but PV is panda 1, is this correct?
oliwenmandiamond
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A second Panda was required to facilitate inter-panda triggering for a P51 scan.
Inter-panda triggering functionality has been tested by loading two_panda_trigger plan in bl51p-ts-panda-01 and working_interPandaTriggering in bl51p-ts-panda-02, with the following scan parameters:
seq_table(start = 1, stop = 10, stepsize = 1, time_per_point = 0.5, motor = bc.devices.turbo_slit_x, add_sweep_triggers=True, number_of_sweeps= 8, detectors = [bc.devices.panda1, bc.devices.panda2])