Skip to content

Update pmac from beamline#1992

Merged
noemifrisina merged 3 commits intomainfrom
1991-update-pmac
Apr 10, 2026
Merged

Update pmac from beamline#1992
noemifrisina merged 3 commits intomainfrom
1991-update-pmac

Conversation

@phathaway
Copy link
Copy Markdown
Contributor

Fixes #1991

Instructions to reviewer on how to test:

  1. Run tests - check passing

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@phathaway phathaway requested a review from a team as a code owner March 25, 2026 16:19
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (fe5c9c0) to head (4405c5c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1992   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         319      319           
  Lines       12408    12408           
=======================================
  Hits        12295    12295           
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@noemifrisina noemifrisina merged commit 5ff8c2a into main Apr 10, 2026
10 checks passed
@noemifrisina noemifrisina deleted the 1991-update-pmac branch April 10, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I24ssx: update pmac

2 participants