Skip to content

Fix for smargon combined moves with current slow-smargon workaround#1999

Open
rtuck99 wants to merge 3 commits intomx-bluesky_1598_mod_360from
1998_serialize_omega_combined_move
Open

Fix for smargon combined moves with current slow-smargon workaround#1999
rtuck99 wants to merge 3 commits intomx-bluesky_1598_mod_360from
1998_serialize_omega_combined_move

Conversation

@rtuck99
Copy link
Copy Markdown
Contributor

@rtuck99 rtuck99 commented Mar 30, 2026

Fixes

Requires:

This removes support for omega in CombinedMove as described in the accompanying mx-bluesky PR

See also mx-bluesky PR

Instructions to reviewer on how to test:

  1. Tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@rtuck99 rtuck99 force-pushed the mx-bluesky_1598_mod_360 branch from a95aa88 to b610d52 Compare April 2, 2026 12:55
@rtuck99 rtuck99 added this to Hyperion Apr 8, 2026
@rtuck99 rtuck99 moved this to In Progress in Hyperion Apr 8, 2026
@rtuck99 rtuck99 force-pushed the 1998_serialize_omega_combined_move branch from 241cf4f to e1bd869 Compare April 8, 2026 09:21
@rtuck99 rtuck99 force-pushed the mx-bluesky_1598_mod_360 branch from e2e258a to 80649ec Compare April 8, 2026 14:36
@rtuck99 rtuck99 force-pushed the 1998_serialize_omega_combined_move branch from e1bd869 to c7b5425 Compare April 8, 2026 14:40
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.09%. Comparing base (e2a80c1) to head (81d30c6).
⚠️ Report is 2 commits behind head on mx-bluesky_1598_mod_360.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           mx-bluesky_1598_mod_360    #1999   +/-   ##
========================================================
  Coverage                    99.08%   99.09%           
========================================================
  Files                          320      320           
  Lines                        12486    12480    -6     
========================================================
- Hits                         12372    12367    -5     
+ Misses                         114      113    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 marked this pull request as ready for review April 9, 2026 08:59
@rtuck99 rtuck99 requested a review from a team as a code owner April 9, 2026 08:59
@rtuck99 rtuck99 force-pushed the 1998_serialize_omega_combined_move branch from c47a689 to 81d30c6 Compare April 9, 2026 09:30
@rtuck99 rtuck99 moved this from In Progress to Review in Hyperion Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

1 participant