Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2001 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 326 326
Lines 12512 12512
=======================================
Hits 12399 12399
Misses 113 113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DominicOram
requested changes
Apr 21, 2026
Contributor
DominicOram
left a comment
There was a problem hiding this comment.
Great, thanks. This now connects but could you change the names of the enums themselves to more closely match the actual valves?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates vici valve names from the placeholders they were set to before. The correct names can be found with
caget -d31 BL21B-EA-GIR-01:VALVE1:POSNcaget -d31 BL21B-EA-GIR-01:VALVE2:POSNInstructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}