Skip to content

Add i15-1 hexapod motors for crystallography-bluesky#9#2002

Merged
EmsArnold merged 3 commits intomainfrom
cb9hexapod
Apr 15, 2026
Merged

Add i15-1 hexapod motors for crystallography-bluesky#9#2002
EmsArnold merged 3 commits intomainfrom
cb9hexapod

Conversation

@Mark-Booth
Copy link
Copy Markdown
Member

Fixes crystallography-bluesky#9

Instructions to reviewer on how to test:

  1. Wait for missing i15-1 motors to be restored
  2. Confirm dodal connect i15-1 runs.
  3. Confirm which axes are X, Y and Z.

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

TODO: Confirm X, Y & Z axes are beamline standard

@Mark-Booth Mark-Booth requested a review from a team as a code owner March 31, 2026 15:10
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (5ff8c2a) to head (acf0d0e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2002   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         319      319           
  Lines       12408    12414    +6     
=======================================
+ Hits        12295    12301    +6     
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@jacob720 jacob720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Motors still offline so haven't been able to do dodal connect, but looks good, happy to be merged once naming is addressed

Comment thread src/dodal/beamlines/i15_1.py Outdated


@devices.factory()
def h() -> XYZStage:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a more explicit name here would be good

Comment thread src/dodal/beamlines/i15_1.py Outdated


@devices.factory()
def hr() -> XYZStage:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@EmsArnold
Copy link
Copy Markdown
Contributor

EmsArnold commented Apr 14, 2026

Motors still offline so haven't been able to do dodal connect, but looks good, happy to be merged once naming is addressed

Hexapod is connecting this morning

@EmsArnold
Copy link
Copy Markdown
Contributor

EmsArnold commented Apr 14, 2026

@jacob720 , with regards to the hexapod being two distinct devices, it looks like symmetrie's naming convention for their hexapods is either X, Y, Z, RX, RY, RZ or TX, TY, TZ, RX, RY, RZ. As more than one of these hexapods exist, it is likely worth creating a hexapod device which can follow these conventions, rather than trying to make the hexapod fit a device like a gonio with X, Y, Z, KAPPA, PHI, OMEGA

@EmsArnold EmsArnold merged commit 63b5340 into main Apr 15, 2026
10 checks passed
@EmsArnold EmsArnold deleted the cb9hexapod branch April 15, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i15-1: Add hexapod

3 participants