Skip to content

Update config server on i19-1#2011

Merged
noemifrisina merged 1 commit into
mainfrom
i19-update-config-server
Apr 17, 2026
Merged

Update config server on i19-1#2011
noemifrisina merged 1 commit into
mainfrom
i19-update-config-server

Conversation

@noemifrisina
Copy link
Copy Markdown
Collaborator

Updates config_client on i19-1 and the and paths to the oav parameter files

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link
Copy Markdown
Contributor

@jacob720 jacob720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (8cf8dfb) to head (82911d1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2011   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         319      319           
  Lines       12412    12416    +4     
=======================================
+ Hits        12299    12303    +4     
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noemifrisina noemifrisina merged commit b73b770 into main Apr 17, 2026
10 checks passed
@noemifrisina noemifrisina deleted the i19-update-config-server branch April 17, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants