Skip to content

Add I06 stages#2017

Merged
oliwenmandiamond merged 10 commits into
mainfrom
i06-peem-manipulator
Apr 22, 2026
Merged

Add I06 stages#2017
oliwenmandiamond merged 10 commits into
mainfrom
i06-peem-manipulator

Conversation

@oliwenmandiamond
Copy link
Copy Markdown
Contributor

@oliwenmandiamond oliwenmandiamond commented Apr 20, 2026

Fixes #2020

Instructions to reviewer on how to test:

  1. Check dodal connect
  2. Check tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@oliwenmandiamond oliwenmandiamond changed the title I06 peem manipulator Add I06 stages Apr 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.09%. Comparing base (1bf067c) to head (c2bb1fb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2017   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         319      326    +7     
  Lines       12426    12505   +79     
=======================================
+ Hits        12313    12392   +79     
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oliwenmandiamond oliwenmandiamond marked this pull request as ready for review April 22, 2026 13:30
@oliwenmandiamond oliwenmandiamond requested a review from a team as a code owner April 22, 2026 13:30
Comment thread src/dodal/devices/beamlines/i06_1/motors.py Outdated
x_infix: str = _X,
y_infix: str = _Y,
phi_infix: str = _PHI,
es_infix: str = "ES:TRANS",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% not important

Suggested change
es_infix: str = "ES:TRANS",
es_suffix: str = "ES:TRANS",

@oliwenmandiamond oliwenmandiamond merged commit cb0a654 into main Apr 22, 2026
10 checks passed
@oliwenmandiamond oliwenmandiamond deleted the i06-peem-manipulator branch April 22, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add I06 sample stages

2 participants