Skip devices expected to be off#2018
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2018 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 326 326
Lines 12507 12507
=======================================
Hits 12394 12394
Misses 113 113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DominicOram
approved these changes
Apr 23, 2026
Contributor
DominicOram
left a comment
There was a problem hiding this comment.
Thanks. Can you add comments next to all the ones that are skipped about why? Once tht's done happy for you to merge
b42fefe to
5a8ac83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DiamondLightSource/crystallography-bluesky#30
Skips devices that we expect to be off. Attenuator is not off but is currently broken.
Instructions to reviewer on how to test:
dodal connect i15_1dodal connect i15_1clean,slits_1,xtal)Checks for reviewer
dodal connect ${BEAMLINE}