Skip to content

Skip devices expected to be off#2018

Merged
jacob720 merged 3 commits into
mainfrom
cryst_bluesky_30_skip_off_devices
Apr 24, 2026
Merged

Skip devices expected to be off#2018
jacob720 merged 3 commits into
mainfrom
cryst_bluesky_30_skip_off_devices

Conversation

@jacob720
Copy link
Copy Markdown
Contributor

@jacob720 jacob720 commented Apr 20, 2026

Fixes DiamondLightSource/crystallography-bluesky#30
Skips devices that we expect to be off. Attenuator is not off but is currently broken.

Instructions to reviewer on how to test:

  1. Do dodal connect i15_1
  2. Confirm all devices connect other than attenuator
  3. checkout main, do another dodal connect i15_1
  4. Confirm the devices skipped in this PR don't connect (clean, slits_1, xtal)

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@jacob720 jacob720 requested a review from a team as a code owner April 20, 2026 17:06
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.09%. Comparing base (257b180) to head (244a46d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2018   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         326      326           
  Lines       12507    12507           
=======================================
  Hits        12394    12394           
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you add comments next to all the ones that are skipped about why? Once tht's done happy for you to merge

@jacob720 jacob720 force-pushed the cryst_bluesky_30_skip_off_devices branch from b42fefe to 5a8ac83 Compare April 24, 2026 10:14
@jacob720 jacob720 enabled auto-merge (squash) April 24, 2026 10:14
@jacob720 jacob720 merged commit 162b497 into main Apr 24, 2026
9 checks passed
@jacob720 jacob720 deleted the cryst_bluesky_30_skip_off_devices branch April 24, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip devices that are expected to be off

2 participants