Fix issues in latest Hyperion version#512
Merged
DominicOram merged 4 commits intomainfrom May 16, 2024
Merged
Conversation
… it doesn't exist
olliesilvester
approved these changes
May 16, 2024
Contributor
olliesilvester
left a comment
olliesilvester
left a comment
There was a problem hiding this comment.
Looks good. One optional comment
| """ | ||
| filename_str = self.filename.get() | ||
| directory_str = self.directory.get() | ||
| directory_str = Path(self.directory.get()) # type: ignore |
Contributor
There was a problem hiding this comment.
NIT: Maybe misleading variable name since it's type Path not string. Also, nothing complains for me if I remove the type ignore
olliesilvester
approved these changes
May 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
===========================================
- Coverage 92.78% 82.44% -10.35%
===========================================
Files 99 98 -1
Lines 3769 3719 -50
===========================================
- Hits 3497 3066 -431
- Misses 272 653 +381 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See DiamondLightSource/hyperion#1343
Instructions to reviewer on how to test:
Checks for reviewer