724 create an ophyd device for apple 2 undulator and add i10 as a beamline#744
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
==========================================
+ Coverage 95.20% 95.58% +0.38%
==========================================
Files 120 125 +5
Lines 4984 5419 +435
==========================================
+ Hits 4745 5180 +435
Misses 239 239 ☔ View full report in Codecov by Sentry. |
stan-dot
left a comment
There was a problem hiding this comment.
requests for clarity in some places
very odd failing test, just in python3.10. also rebasing does not work |
This was cause by this python/cpython#86579 but the strange thing for me is, the test should have never passed before. |
stan-dot
left a comment
There was a problem hiding this comment.
small changes to typing
| def __init__( | ||
| self, | ||
| prefix: str, | ||
| grating: type[Enum], |
There was a problem hiding this comment.
could: replace with a direct reference to I10Grating class? later on could be added or OtherGrating ?
Fixes #724
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}