Make sure backlight is moved in/out when set#767
Merged
DominicOram merged 5 commits intomainfrom Sep 4, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 115 115
Lines 4617 4622 +5
=======================================
+ Hits 4365 4370 +5
Misses 252 252 ☔ View full report in Codecov by Sentry. |
olliesilvester
approved these changes
Sep 3, 2024
Contributor
olliesilvester
left a comment
There was a problem hiding this comment.
Maybe should write tests here but the logic is so simple so I doubt I'd have bothered either. How confident are we about the 1 second?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DiamondLightSource/mx-bluesky#198
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}