Skip to content

Make sure backlight is moved in/out when set#767

Merged
DominicOram merged 5 commits intomainfrom
hyperion_1549_wait_for_backlight_move
Sep 4, 2024
Merged

Make sure backlight is moved in/out when set#767
DominicOram merged 5 commits intomainfrom
hyperion_1549_wait_for_backlight_move

Conversation

@DominicOram
Copy link
Contributor

Fixes DiamondLightSource/mx-bluesky#198

Instructions to reviewer on how to test:

  1. Confirm this would make sure we move the backlight out properly

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (da0bb3c) to head (52d2fb0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #767   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files         115      115           
  Lines        4617     4622    +5     
=======================================
+ Hits         4365     4370    +5     
  Misses        252      252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe should write tests here but the logic is so simple so I doubt I'd have bothered either. How confident are we about the 1 second?

Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DominicOram DominicOram merged commit 08c2764 into main Sep 4, 2024
@DominicOram DominicOram deleted the hyperion_1549_wait_for_backlight_move branch September 4, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wait for backlight to move out before datacollection

2 participants