Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 115 115
Lines 4621 4621
=======================================
Hits 4368 4368
Misses 253 253 ☔ View full report in Codecov by Sentry. |
noemifrisina
approved these changes
Sep 3, 2024
Collaborator
noemifrisina
left a comment
There was a problem hiding this comment.
lgtm, thanks.
Do we have an issue here in Dodal to remove this once the issue in epics-base is merged? If not, can we open one please?
Contributor
Author
|
I've made DiamondLightSource/mx-bluesky#451 to cover both here and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we're getting depreciation warnings on
setuptools_dso, we're now treating these as errors so running tests etc. will fail. This will temporarily suppress the warning.Instructions to reviewer on how to test:
mainrunpytest .and see it fails with a depreciation warning onsetuptools_dsoChecks for reviewer
dodal connect ${BEAMLINE}