Skip to content

Supress warnings from setuptools_dso#768

Merged
DominicOram merged 1 commit intomainfrom
suppress_setuptools_warning
Sep 3, 2024
Merged

Supress warnings from setuptools_dso#768
DominicOram merged 1 commit intomainfrom
suppress_setuptools_warning

Conversation

@DominicOram
Copy link
Contributor

Currently we're getting depreciation warnings on setuptools_dso, we're now treating these as errors so running tests etc. will fail. This will temporarily suppress the warning.

Instructions to reviewer on how to test:

  1. On main run pytest . and see it fails with a depreciation warning on setuptools_dso
  2. Do the same on this branch and it passes

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram DominicOram marked this pull request as ready for review September 2, 2024 08:24
@codecov
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.52%. Comparing base (c3ad7e4) to head (3140325).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #768   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files         115      115           
  Lines        4621     4621           
=======================================
  Hits         4368     4368           
  Misses        253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.
Do we have an issue here in Dodal to remove this once the issue in epics-base is merged? If not, can we open one please?

@DominicOram
Copy link
Contributor Author

I've made DiamondLightSource/mx-bluesky#451 to cover both here and mx-bluesky as we'll need to do both

@DominicOram DominicOram merged commit 8702cc8 into main Sep 3, 2024
@DominicOram DominicOram deleted the suppress_setuptools_warning branch September 3, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants