Skip to content

Add signals for current puck and pin#785

Merged
DominicOram merged 4 commits intomainfrom
mx_bluesky_240_do_not_reload
Sep 13, 2024
Merged

Add signals for current puck and pin#785
DominicOram merged 4 commits intomainfrom
mx_bluesky_240_do_not_reload

Conversation

@DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Sep 12, 2024

See DiamondLightSource/mx-bluesky#240

Instructions to reviewer on how to test:

  1. Run dodal connect i03 and confirm new signals connect

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (212141f) to head (040a728).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #785   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files         115      115           
  Lines        4654     4656    +2     
=======================================
+ Hits         4417     4419    +2     
  Misses        237      237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@DominicOram DominicOram merged commit 69bd320 into main Sep 13, 2024
@DominicOram DominicOram deleted the mx_bluesky_240_do_not_reload branch September 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants