Skip to content

Wait for set to finish after focus mirrors finish slew#800

Merged
DominicOram merged 1 commit intomainfrom
mx_bluesky_277_energy_change_hotfixes
Sep 24, 2024
Merged

Wait for set to finish after focus mirrors finish slew#800
DominicOram merged 1 commit intomainfrom
mx_bluesky_277_energy_change_hotfixes

Conversation

@DominicOram
Copy link
Contributor

Part of DiamondLightSource/mx-bluesky#277

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (eece064) to head (ef88f63).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #800   +/-   ##
=======================================
  Coverage   94.99%   95.00%           
=======================================
  Files         115      115           
  Lines        4719     4720    +1     
=======================================
+ Hits         4483     4484    +1     
  Misses        236      236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@DominicOram DominicOram merged commit 1975af4 into main Sep 24, 2024
@DominicOram DominicOram deleted the mx_bluesky_277_energy_change_hotfixes branch September 24, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants