Skip to content

Make backlight timing a float#831

Merged
d-perl merged 2 commits intomainfrom
mx_bluesky_479_tidy_up_tests
Oct 11, 2024
Merged

Make backlight timing a float#831
d-perl merged 2 commits intomainfrom
mx_bluesky_479_tidy_up_tests

Conversation

@DominicOram
Copy link
Contributor

Needed to help typing in DiamondLightSource/mx-bluesky#560

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.02%. Comparing base (c2096b6) to head (fed070a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #831   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files         117      117           
  Lines        4765     4765           
=======================================
  Hits         4528     4528           
  Misses        237      237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-perl d-perl merged commit 9cb9596 into main Oct 11, 2024
@d-perl d-perl deleted the mx_bluesky_479_tidy_up_tests branch October 11, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants