Prevent simulated connect from trying to connect to real devices on i22#849
Merged
DiamondJoseph merged 1 commit intomainfrom Oct 17, 2024
Merged
Prevent simulated connect from trying to connect to real devices on i22#849DiamondJoseph merged 1 commit intomainfrom
DiamondJoseph merged 1 commit intomainfrom
Conversation
callumforrester
approved these changes
Oct 17, 2024
Contributor
|
Looks like this also fixes #847 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
=======================================
Coverage 95.19% 95.19%
=======================================
Files 120 120
Lines 4976 4976
=======================================
Hits 4737 4737
Misses 239 239 ☔ View full report in Codecov by Sentry. |
DiamondJoseph
changed the title
rtuck99
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Revert "Prevent devices connecting as side effect of use elsewhere (#860)" This reverts commit 52848b3. * Revert " Prevent simulated connect from trying to connect to real device (#849)" This reverts commit ecc1a20. * Revert "Add deprecation warning to inject (#854)" This reverts commit 0f8989e. * Revert "Isolated device factory (#841)" This reverts commit 0ba531c.
callumforrester
pushed a commit
that referenced
this pull request
Nov 1, 2024
callumforrester
pushed a commit
that referenced
this pull request
Nov 5, 2024
callumforrester
pushed a commit
that referenced
this pull request
Nov 6, 2024
callumforrester
pushed a commit
that referenced
this pull request
Nov 11, 2024
callumforrester
pushed a commit
that referenced
this pull request
Nov 20, 2024
callumforrester
pushed a commit
that referenced
this pull request
Nov 20, 2024
callumforrester
pushed a commit
that referenced
this pull request
Nov 25, 2024
callumforrester
pushed a commit
that referenced
this pull request
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #848, #847
Checks for reviewer
dodal connect ${BEAMLINE}