Skip to content

Update to work with next version of ophyd-async#899

Merged
DominicOram merged 7 commits intomainfrom
test_ophyd_async_646
Nov 19, 2024
Merged

Update to work with next version of ophyd-async#899
DominicOram merged 7 commits intomainfrom
test_ophyd_async_646

Conversation

@DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Nov 12, 2024

Update to work with bluesky/ophyd-async#646. Wait for that to be merged + new ophyd-async release before merging this.

Contains fix from #903 so merge that first

Instructions to reviewer on how to test:

  1. Confirm tests still pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.78%. Comparing base (82d6afc) to head (4b03309).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #899      +/-   ##
==========================================
- Coverage   95.78%   95.78%   -0.01%     
==========================================
  Files         133      133              
  Lines        5479     5476       -3     
==========================================
- Hits         5248     5245       -3     
  Misses        231      231              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@stan-dot
Copy link
Contributor

stan-dot commented Nov 14, 2024

@DominicOram can we get a specific version number of ophyd-async for this please?

@DominicOram
Copy link
Contributor Author

DominicOram commented Nov 14, 2024

It's whatever the next version of ophyd-async will be so I assume 0.8.0 or maybe 0.8.0a5. Basically, this should match what is on ophyd-async main currently

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Copy link
Collaborator

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants