Update to work with next version of ophyd-async#899
Merged
DominicOram merged 7 commits intomainfrom Nov 19, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
==========================================
- Coverage 95.78% 95.78% -0.01%
==========================================
Files 133 133
Lines 5479 5476 -3
==========================================
- Hits 5248 5245 -3
Misses 231 231 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Contributor
|
@DominicOram can we get a specific version number of ophyd-async for this please? |
Contributor
Author
|
It's whatever the next version of |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to work with bluesky/ophyd-async#646. Wait for that to be merged + new ophyd-async release before merging this.
Contains fix from #903 so merge that first
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}