Merged
Conversation
4 tasks
602459f to
7518e67
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
=======================================
Coverage 96.04% 96.05%
=======================================
Files 136 136
Lines 5645 5653 +8
=======================================
+ Hits 5422 5430 +8
Misses 223 223 ☔ View full report in Codecov by Sentry. |
DominicOram
approved these changes
Nov 27, 2024
Contributor
DominicOram
left a comment
There was a problem hiding this comment.
Thanks! This may change with some of my suggestions on the mx-bluesky side but given the current structure this is good
a0cab60 to
eb47b4d
Compare
Remove vfm lateral lookup table as it was constant anyway Add waits for various motions that can't be parallelised
eb47b4d to
24617fb
Compare
huw-dls
pushed a commit
that referenced
this pull request
Dec 18, 2024
* Energy-related hotfixes from beamline testing 2024-11-12 * Add vfm yaw and lat changes on mirror stripe change Remove vfm lateral lookup table as it was constant anyway Add waits for various motions that can't be parallelised * Changes in response to PR comments * Move dcm offset to the undulator_dcm instead of in the device plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dodal changes for DiamondLightSource/mx-bluesky#651
See MX-bluesky PR DiamondLightSource/mx-bluesky#676
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}