Update p45 to ophyd_async devices, device_factory#919
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
=======================================
Coverage 97.69% 97.69%
=======================================
Files 160 160
Lines 6635 6638 +3
=======================================
+ Hits 6482 6485 +3
Misses 153 153 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I would be happy to review this but don't really use P45 so wouldn't know how to do |
|
p45 has been mildly on fire (literally melted some of the server and some of the IOCs are unplugged) recently, so this is fairly low priority. I'm happy to close and maybe even delete the p45 beamline for now. |
I would either merge this as is w/o necessarily being tested or remove p45 all together, up to you. Depends on if p45 is coming back soon or not. Either way, leaving the old style instantiation around is bad. |
|
Let's merge it, they're all simple devices and after rebasing it looks like it's just the DeviceFactory change which is pretty uncontroversial now. |
Ok, I will review it quickly now for obvious problems, without testing against the real thing |
DominicOram
left a comment
There was a problem hiding this comment.
As discussed, hard to test properly with p45 not up but looks correct.
Updates p45 device classes to be ophyd-async compatible, replaces use of
device_instantiationwith@device_factory.Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}