Merged
Conversation
…to avoid member name clash
Collaborator
Author
|
Updates made per Joseph's comment. |
callumforrester
suggested changes
Dec 11, 2024
Contributor
callumforrester
left a comment
callumforrester
left a comment
There was a problem hiding this comment.
Looking good Dan, most comments are minor
Comment on lines
+26
to
+40
| class BimorphMirrorOnOff(StrictEnum): | ||
| ON = "ON" | ||
| OFF = "OFF" | ||
|
|
||
|
|
||
| class BimorphMirrorMode(StrictEnum): | ||
| HI = "HI" | ||
| NORMAL = "NORMAL" | ||
| FAST = "FAST" | ||
|
|
||
|
|
||
| class BimorphMirrorStatus(StrictEnum): | ||
| IDLE = "Idle" | ||
| BUSY = "Busy" | ||
| ERROR = "Error" |
Co-authored-by: Callum Forrester <callum.forrester@diamond.ac.uk>
Co-authored-by: Callum Forrester <callum.forrester@diamond.ac.uk>
Co-authored-by: Callum Forrester <callum.forrester@diamond.ac.uk>
callumforrester
approved these changes
Dec 11, 2024
Co-authored-by: Callum Forrester <callum.forrester@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
BimorphMirrordevice, representing an n-channel CAENels Bimorph Mirror.My general questions:
forloops. Could these be improved by collecting results and asserting all of collection?valid_bimorph_valuesfixture that generates a prandom set of correct inputs. Does it matter that this is generated at collection? Could there be a test case where multiple sets of randomly generated inputs are require, and in this case would it be better to implement input generation using a factory pattern?mirrorfixture will definitely be executed before its needed. However, only one reference to themirrorfixtures passes the requirednumber_of_channelsparameter. Is this an issue? (Does this question make sense?)Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}