Skip to content

Returning capitalized aperture value name for ApertureValue enum#953

Merged
olliesilvester merged 2 commits intomainfrom
452_ugly_aperture_value_name
Dec 10, 2024
Merged

Returning capitalized aperture value name for ApertureValue enum#953
olliesilvester merged 2 commits intomainfrom
452_ugly_aperture_value_name

Conversation

@shihab-dls
Copy link
Contributor

@shihab-dls shihab-dls commented Dec 9, 2024

Fixes #452

Instructions to reviewer on how to test:

  1. Check if ApertureValue, formatted as a comment, returns names such as "Small" instead of "ApertureValue.SMALL".

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@shihab-dls shihab-dls requested a review from a team as a code owner December 9, 2024 17:56
@codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.17%. Comparing base (f9b3fd0) to head (4b25999).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #953   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files         134      134           
  Lines        5629     5631    +2     
=======================================
+ Hits         5470     5472    +2     
  Misses        159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@olliesilvester olliesilvester merged commit 4b224c1 into main Dec 10, 2024
@olliesilvester olliesilvester deleted the 452_ugly_aperture_value_name branch December 10, 2024 17:44
huw-dls pushed a commit that referenced this pull request Dec 18, 2024
Co-authored-by: Shihab Suliman <rye74444@ws557.diamond.ac.uk>
Co-authored-by: olliesilvester <122091460+olliesilvester@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ApertureScatterguard Aperture setting comment is "ugly"

2 participants