Use Reference to prevent Device name mangling of undulator and dcm#957
Use Reference to prevent Device name mangling of undulator and dcm#957shihab-dls merged 3 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #957 +/- ##
==========================================
+ Coverage 95.80% 97.38% +1.57%
==========================================
Files 144 143 -1
Lines 6179 6079 -100
==========================================
Hits 5920 5920
+ Misses 259 159 -100 ☔ View full report in Codecov by Sentry. |
|
Thanks for this Shihab! If you run the unit tests and search around in mx-bluesky you will find that there are several places where there are similar dereferences of You might also want to alter the name of these to make it clear that they are reference wrappers rather than the actual devices - elsewhere where I have added them I have suffixed the names with A second consideration is whether to make them private by prefixing an underscore, however I think in this case it's ok to leave them public as it's probably both expected and useful to expose the undulator and DCM devices that are backing this composite. |
|
Thanks Rob! I've opened up a PR in mx-bluesky amending the exposed references, so I'll tag you and Ollie as reviewers on that one. |
Fixes #929
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}