Skip to content

Add "Reset" epics signal#968

Merged
shihab-dls merged 2 commits intomainfrom
add_reset_signal_bart_robot
Dec 20, 2024
Merged

Add "Reset" epics signal#968
shihab-dls merged 2 commits intomainfrom
add_reset_signal_bart_robot

Conversation

@shihab-dls
Copy link
Contributor

Fixes 505

Instructions to reviewer on how to test:

  1. Check if correct signal has been added to clear robot error
  2. Check if amended error_code type is fine

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@shihab-dls shihab-dls requested a review from a team as a code owner December 19, 2024 12:09
@codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.44%. Comparing base (5a4a7ab) to head (00858ea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #968   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files         144      144           
  Lines        6139     6140    +1     
=======================================
+ Hits         5982     5983    +1     
  Misses        157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! See suggested variable name though

@shihab-dls shihab-dls merged commit 75f1019 into main Dec 20, 2024
@shihab-dls shihab-dls deleted the add_reset_signal_bart_robot branch December 20, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clear robot load error 40

2 participants