Skip to content

Add Panda to Training Rigs#980

Merged
ZohebShaikh merged 2 commits intomainfrom
htss-rig-update
Jan 14, 2025
Merged

Add Panda to Training Rigs#980
ZohebShaikh merged 2 commits intomainfrom
htss-rig-update

Conversation

@ZohebShaikh
Copy link
Contributor

Fixes DiamondLightSource/htss-rig-bluesky#46

Instructions to reviewer on how to test:

  1. Clone and run system test on htss-rig-bluesky

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@ZohebShaikh ZohebShaikh requested a review from a team as a code owner January 10, 2025 11:57
@codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (e2a9b9f) to head (2b02ea4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #980   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         151      151           
  Lines        6290     6294    +4     
=======================================
+ Hits         6132     6136    +4     
  Misses        158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZohebShaikh ZohebShaikh requested review from callumforrester and removed request for callumforrester January 10, 2025 13:50
Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZohebShaikh ZohebShaikh changed the title Added Panda to htss-rig-bluesky Add Panda to Training Rigs Jan 13, 2025
@ZohebShaikh ZohebShaikh merged commit 4263907 into main Jan 14, 2025
@ZohebShaikh ZohebShaikh deleted the htss-rig-update branch January 14, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade plans to latest release of ophyd-async

2 participants