Skip to content

Add import linting#988

Merged
shihab-dls merged 10 commits intomainfrom
840_enfore_imports
Jan 15, 2025
Merged

Add import linting#988
shihab-dls merged 10 commits intomainfrom
840_enfore_imports

Conversation

@shihab-dls
Copy link
Contributor

Fixes #840

Instructions to reviewer on how to test:

  1. Confirm correct import directionality

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@shihab-dls shihab-dls requested a review from a team as a code owner January 14, 2025 14:54
@shihab-dls
Copy link
Contributor Author

shihab-dls commented Jan 14, 2025

This import rules defined are described by this figure.
Screenshot from 2025-01-15 10-20-01

@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (4263907) to head (008533d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #988   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         151      151           
  Lines        6294     6294           
=======================================
  Hits         6136     6136           
  Misses        158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shihab-dls shihab-dls merged commit a44bce1 into main Jan 15, 2025
@shihab-dls shihab-dls deleted the 840_enfore_imports branch January 15, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add linter to enforce import rules

2 participants