Skip to content

Disable polling of config parameters and update in a separate loop#18

Merged
GDYendell merged 4 commits intomainfrom
config-fetch
Dec 12, 2023
Merged

Disable polling of config parameters and update in a separate loop#18
GDYendell merged 4 commits intomainfrom
config-fetch

Conversation

@GDYendell
Copy link
Contributor

@GDYendell GDYendell commented Nov 28, 2023

Some tweaks to the FastCS core could make this a bit neater, but it works for now.

@GDYendell GDYendell requested a review from TBThomas56 November 28, 2023 16:17
@codecov
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (a5b2021) 41.33% compared to head (7d0fbd9) 39.56%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/eiger_fastcs/eiger_controller.py 35.41% 31 Missing ⚠️
src/eiger_fastcs/__main__.py 30.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   41.33%   39.56%   -1.78%     
==========================================
  Files           3        3              
  Lines         150      182      +32     
==========================================
+ Hits           62       72      +10     
- Misses         88      110      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GDYendell GDYendell force-pushed the config-fetch branch 4 times, most recently from ab39bfd to 5aef7d2 Compare November 29, 2023 10:58
@GDYendell
Copy link
Contributor Author

I need to remind myself if there is a good reason that the current logic is complicated and if we should just clear the set and let it fill up again while fetching. I think if the same parameter is added again, we can't be sure if we updated before or after, so we should just update it again.

Copy link
Contributor

@TBThomas56 TBThomas56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gary - "Is a good reason that the current logic is complicated and if we should just clear the set and let it fill up again while fetching. I think if the same parameter is added again, we can't be sure if we updated before or after, so we should just update it again."

Make config parameters only update once on startup
Update put to handle response and trigger the returned parameters
to be updated.
Add update loop to request specific parameters that need updating
Remove name from LogicHandler
Explicitly define ntrigger to use in code
Use Attribute.get() instead of Attribute._value
Remove TODO - No sleep is required
These should not be included in the PV interface or polled
@GDYendell GDYendell merged commit 855154a into main Dec 12, 2023
@GDYendell GDYendell deleted the config-fetch branch December 12, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants