Disable polling of config parameters and update in a separate loop#18
Disable polling of config parameters and update in a separate loop#18
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
- Coverage 41.33% 39.56% -1.78%
==========================================
Files 3 3
Lines 150 182 +32
==========================================
+ Hits 62 72 +10
- Misses 88 110 +22 ☔ View full report in Codecov by Sentry. |
ab39bfd to
5aef7d2
Compare
|
I need to remind myself if there is a good reason that the current logic is complicated and if we should just clear the set and let it fill up again while fetching. I think if the same parameter is added again, we can't be sure if we updated before or after, so we should just update it again. |
TBThomas56
left a comment
There was a problem hiding this comment.
Gary - "Is a good reason that the current logic is complicated and if we should just clear the set and let it fill up again while fetching. I think if the same parameter is added again, we can't be sure if we updated before or after, so we should just update it again."
5aef7d2 to
83fd272
Compare
Make config parameters only update once on startup Update put to handle response and trigger the returned parameters to be updated. Add update loop to request specific parameters that need updating
These should not be included in the PV interface or polled
83fd272 to
7d0fbd9
Compare
Some tweaks to the FastCS core could make this a bit neater, but it works for now.