fetch bit_depth_* parameters before returning from put#61
Merged
Conversation
GDYendell
approved these changes
Mar 5, 2025
Contributor
GDYendell
left a comment
GDYendell
left a comment
There was a problem hiding this comment.
Looks good. I guess this depends on the eiger-stream2 branch of the tickit sim that has the put responses?
jsouter
force-pushed
the
fetch-before-return
branch
from
efef44b to
ef4ecd2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 83.94% 84.61% +0.66%
==========================================
Files 4 4
Lines 299 312 +13
==========================================
+ Hits 251 264 +13
Misses 48 48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Yeah, that's pinned in the pyproject.toml at least |
GDYendell
reviewed
Mar 5, 2025
GDYendell
reviewed
Mar 11, 2025
jsouter
force-pushed
the
fetch-before-return
branch
from
46eb54c to
3061596
Compare
GDYendell
reviewed
Mar 14, 2025
GDYendell
reviewed
Mar 14, 2025
jsouter
force-pushed
the
fetch-before-return
branch
from
af5952a to
c53f1c6
Compare
jsouter
force-pushed
the
fetch-before-return
branch
from
bdb82f4 to
38400f2
Compare
GDYendell
reviewed
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59