Set prec field based on min value during introspection#64
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 86.02% 86.40% +0.37%
==========================================
Files 5 5
Lines 322 331 +9
==========================================
+ Hits 277 286 +9
Misses 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DominicOram
left a comment
There was a problem hiding this comment.
Looks good, thanks. Can we have some additional tests on if min comes back as not a float and maybe just parameterize a bunch of other potential values of min and what you would expect the prec to be
DominicOram
left a comment
There was a problem hiding this comment.
As found on the beamline you can get mins come in with 1e-7 notation . Can we have some tests on that?
|
Converting |
DominicOram
left a comment
There was a problem hiding this comment.
One minor comment in code, take it or leave it. Is there also a bug here where if the min comes back as positive e.g. 1e10 it will have a prec of 10? It's probably not a massive issue
Fixes #63
Following #62, we are now be able to set the
precfield of attributes by parsing theirminvalue.