Conversation
GDYendell
force-pushed
the
string-datatype
branch
from
927c2fa to
3d6f1d8
Compare
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 45.49% 45.19% -0.31%
==========================================
Files 17 17
Lines 611 624 +13
==========================================
+ Hits 278 282 +4
- Misses 333 342 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MJGaughran
approved these changes
Oct 13, 2023
GDYendell
force-pushed
the
string-datatype
branch
from
3d6f1d8 to
f804e8a
Compare
Contributor
Author
|
I am going to merge this as is, but possibly we will want to allow developers to create |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for a
StringDataType.The EPICS backend creates
longString{In,Out}records andText{Read,Write}widgets forStrings.Up for discussion whether we want to use
stringinandstringoutrecords in some circumstances. My current thinking is we just use long strings for everything and then we never have to worry about character limits. I don't think there are any downsides to this.