Skip to content

FastCS basic features#6

Merged
MJGaughran merged 19 commits intoDiamondLightSource:mainfrom
MJGaughran:initial-fastcs
Sep 8, 2023
Merged

FastCS basic features#6
MJGaughran merged 19 commits intoDiamondLightSource:mainfrom
MJGaughran:initial-fastcs

Conversation

@MJGaughran
Copy link
Copy Markdown
Collaborator

This includes the basic features of FastCS, including:

  • Attributes and attribute parameters
  • Wrappers and Handler classes for control system interactions
  • EPICS backend, including interactive terminal

This repository works with the following branches:
Demo: https://github.com/MJGaughran/demo-fast-cs/tree/fast-cs-prototype
PVI fixes: https://github.com/epics-containers/pvi/tree/fast-cs-hacks

@MJGaughran MJGaughran requested a review from GDYendell August 11, 2023 12:40
@MJGaughran MJGaughran self-assigned this Aug 11, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 11, 2023

Codecov Report

Merging #6 (7a73434) into main (0cbc02d) will decrease coverage by 54.51%.
The diff coverage is 44.20%.

@@             Coverage Diff              @@
##              main       #6       +/-   ##
============================================
- Coverage   100.00%   45.49%   -54.51%     
============================================
  Files            2       17       +15     
  Lines           16      611      +595     
============================================
+ Hits            16      278      +262     
- Misses           0      333      +333     
Files Changed Coverage Δ
src/fastcs/backends/epics/ioc.py 26.43% <26.43%> (ø)
src/fastcs/backend.py 27.84% <27.84%> (ø)
src/fastcs/backends/epics/gui.py 36.47% <36.47%> (ø)
src/fastcs/mapping.py 39.13% <39.13%> (ø)
src/fastcs/backends/asyncio_backend.py 40.00% <40.00%> (ø)
src/fastcs/connections.py 44.73% <44.73%> (ø)
src/fastcs/wrappers.py 47.36% <47.36%> (ø)
src/fastcs/cs_methods.py 49.09% <49.09%> (ø)
src/fastcs/controller.py 51.72% <51.72%> (ø)
src/fastcs/attributes.py 56.96% <56.96%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass. I think I have looked at about half of it in detail.

Comment thread src/fastcs/attributes.py
Comment thread src/fastcs/attributes.py Outdated
Comment thread src/fastcs/backend.py Outdated
Comment thread src/fastcs/mapping.py Outdated
Comment thread src/fastcs/mapping.py Outdated
Comment thread src/fastcs/backend.py Outdated
Comment thread src/fastcs/backend.py Outdated
Comment thread src/fastcs/backend.py Outdated
Comment thread src/fastcs/mapping.py Outdated
Comment thread src/fastcs/mapping.py Outdated
@MJGaughran
Copy link
Copy Markdown
Collaborator Author

Thanks for the partial review Gary. I think you've cleared up some of my thoughts, as well.

Copy link
Copy Markdown
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments / replies.

Comment thread src/fastcs/attributes.py
Comment thread src/fastcs/backend.py Outdated
Comment thread src/fastcs/backends/asyncio_backend.py
Comment thread src/fastcs/backend.py Outdated
Comment thread src/fastcs/mapping.py Outdated
Comment thread src/fastcs/backend.py Outdated
@GDYendell
Copy link
Copy Markdown
Contributor

New batch of changes look good to me 🙂

@MJGaughran MJGaughran merged commit 00f04e1 into DiamondLightSource:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants