FastCS basic features#6
Merged
MJGaughran merged 19 commits intoDiamondLightSource:mainfrom Sep 8, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
============================================
- Coverage 100.00% 45.49% -54.51%
============================================
Files 2 17 +15
Lines 16 611 +595
============================================
+ Hits 16 278 +262
- Misses 0 333 +333
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
GDYendell
reviewed
Aug 11, 2023
Contributor
GDYendell
left a comment
There was a problem hiding this comment.
First pass. I think I have looked at about half of it in detail.
Collaborator
Author
|
Thanks for the partial review Gary. I think you've cleared up some of my thoughts, as well. |
GDYendell
reviewed
Aug 14, 2023
Contributor
GDYendell
left a comment
There was a problem hiding this comment.
Some more comments / replies.
Naming for methods vs fns is getting confusing.
Contributor
|
New batch of changes look good to me 🙂 |
GDYendell
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the basic features of FastCS, including:
This repository works with the following branches:
Demo: https://github.com/MJGaughran/demo-fast-cs/tree/fast-cs-prototype
PVI fixes: https://github.com/epics-containers/pvi/tree/fast-cs-hacks