Merged
Conversation
Initial go at adding support, doesn't currently load TIFF files. Need to decide whether to add TIFF reader or amend docs and typing to return image filenames. What to do with multi-dimensional scans with filenames? Commit currently non-functional work in progress. Do not merge to main branch.
hdf_loader.py - added standard arguments 'swmr=True' and 'libver=latest' to h5py.File usages. hdfmap_class.py - removed several unused 'info_...' funcitons, replaced with 'info_names(...)' - added first_last_scannables function - added 'numeric_only' option to get_scannables - improved doc strings nexus.py - improved info_nexus output - renamed 'nexus_defaults' to 'nexus_default_paths' - added 'nexus_default_names' - added collection of 'image_data' filename detector datasets, image_data now may contain paths to non-numeric datasets (docs updated) - get_plot_data improved using new functions. test_edge_cases.py - added additional edge case files and regenerated test_files.json pypi-publish.yml - updated to v4 of the artifact actions to fix depreciation error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for detectors with image_data file paths, plus improvements to NeXus defaults and other stuff.
hdf_loader.py
hdfmap_class.py
nexus.py
test_edge_cases.py
pypi-publish.yml