Skip to content

Version 0.9.0#17

Merged
DanPorter merged 3 commits intomasterfrom
identification_of_image_data
Mar 31, 2025
Merged

Version 0.9.0#17
DanPorter merged 3 commits intomasterfrom
identification_of_image_data

Conversation

@DanPorter
Copy link
Copy Markdown
Collaborator

@DanPorter DanPorter commented Mar 31, 2025

Fixes for issue #16

eval_functions.py

  • added min_dim to is_shape(), allowing specification of minumum dataset shape

hdfmap_class.py

  • Removed generate_combined() call from the various generate_scannables methods and instead put it in populate.
  • changed the behaviour of generate_scannables_from_group() so the scannable shape is now the shape of the smallest dataset in the group, rather than the first dataset, avoiding defining the shape as an image dataset.
  • change default detector_image name from 'image_data' to 'IMAGE' to stop conflicts with 'image_data' dataset in scan files.

nexus.py

  • changed behaviour of generate_image_data_from_nxdetector - potential image datasets are now compared against scannables_shape(), this means scannables must be defined first.
  • changed No NXdetector found warning to info as not all scans contain this.
  • changed behaviour of populate() sof image_data is after scannables and generate_combined() is added, consistent with change to hdfmap_class.py
  • added call to generate_scannables to populate

file_functions.py

  • removed "if not nxmap.scannables" and placed this check within NexusMap.populate

tests

  • added additional tests for NXxas scan and 3D hysteresis scan on i10-1.

All tests complete

Fixes for issue #16

eval_functions.py
 - added min_dim to is_shape(), allowing specification of minumum dataset shape

hdfmap_class.py
 - Removed generate_combined() call from the various generate_scannables methods and instead put it in populate.
 - changed the behaviour of generate_scannables_from_group() so the scannable shape is now the shape of the smallest dataset in the group, rather than the first dataset, avoiding defining the shape as an image dataset.

nexus.py
 - changed behaviour of generate_image_data_from_nxdetector - potential image datasets are now compared against scannables_shape(), this means scannables must be defined first.
 - changed No NXdetector found warning to info as not all scans contain this.
 - changed behaviour of populate() sof image_data is after scannables and generate_combined() is added, consistent with change to hdfmap_class.py
 - added call to generate_scannables to populate

file_functions.py
 - removed "if not nxmap.scannables" and placed this check within NexusMap.populate

tests
 - added additional tests for NXxas scan and 3D hysteresis scan on i10-1.

All tests complete
Fixes for issue #16

eval_functions.py
 - added min_dim to is_shape(), allowing specification of minumum dataset shape

hdfmap_class.py
 - Removed generate_combined() call from the various generate_scannables methods and instead put it in populate.
 - changed the behaviour of generate_scannables_from_group() so the scannable shape is now the shape of the smallest dataset in the group, rather than the first dataset, avoiding defining the shape as an image dataset.
 - change default detector_image name from 'image_data' to 'IMAGE' to stop conflits with 'image_data' group in scan files.

nexus.py
 - changed behaviour of generate_image_data_from_nxdetector - potential image datasets are now compared against scannables_shape(), this means scannables must be defined first.
 - changed No NXdetector found warning to info as not all scans contain this.
 - changed behaviour of populate() sof image_data is after scannables and generate_combined() is added, consistent with change to hdfmap_class.py
 - added call to generate_scannables to populate

file_functions.py
 - removed "if not nxmap.scannables" and placed this check within NexusMap.populate

tests
 - added additional tests for NXxas scan and 3D hysteresis scan on i10-1.

All tests complete
Fixes for issue #16

eval_functions.py
 - added min_dim to is_shape(), allowing specification of minumum dataset shape

hdfmap_class.py
 - Removed generate_combined() call from the various generate_scannables methods and instead put it in populate.
 - changed the behaviour of generate_scannables_from_group() so the scannable shape is now the shape of the smallest dataset in the group, rather than the first dataset, avoiding defining the shape as an image dataset.
 - change default detector_image name from 'image_data' to 'IMAGE' to stop conflits with 'image_data' group in scan files.

nexus.py
 - changed behaviour of generate_image_data_from_nxdetector - potential image datasets are now compared against scannables_shape(), this means scannables must be defined first.
 - changed No NXdetector found warning to info as not all scans contain this.
 - changed behaviour of populate() sof image_data is after scannables and generate_combined() is added, consistent with change to hdfmap_class.py
 - added call to generate_scannables to populate

file_functions.py
 - removed "if not nxmap.scannables" and placed this check within NexusMap.populate

tests
 - added additional tests for NXxas scan and 3D hysteresis scan on i10-1.

All tests complete
@DanPorter DanPorter merged commit 3152d82 into master Mar 31, 2025
10 checks passed
@DanPorter DanPorter deleted the identification_of_image_data branch July 7, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant