Conversation
Fixes for issue #16 eval_functions.py - added min_dim to is_shape(), allowing specification of minumum dataset shape hdfmap_class.py - Removed generate_combined() call from the various generate_scannables methods and instead put it in populate. - changed the behaviour of generate_scannables_from_group() so the scannable shape is now the shape of the smallest dataset in the group, rather than the first dataset, avoiding defining the shape as an image dataset. nexus.py - changed behaviour of generate_image_data_from_nxdetector - potential image datasets are now compared against scannables_shape(), this means scannables must be defined first. - changed No NXdetector found warning to info as not all scans contain this. - changed behaviour of populate() sof image_data is after scannables and generate_combined() is added, consistent with change to hdfmap_class.py - added call to generate_scannables to populate file_functions.py - removed "if not nxmap.scannables" and placed this check within NexusMap.populate tests - added additional tests for NXxas scan and 3D hysteresis scan on i10-1. All tests complete
Fixes for issue #16 eval_functions.py - added min_dim to is_shape(), allowing specification of minumum dataset shape hdfmap_class.py - Removed generate_combined() call from the various generate_scannables methods and instead put it in populate. - changed the behaviour of generate_scannables_from_group() so the scannable shape is now the shape of the smallest dataset in the group, rather than the first dataset, avoiding defining the shape as an image dataset. - change default detector_image name from 'image_data' to 'IMAGE' to stop conflits with 'image_data' group in scan files. nexus.py - changed behaviour of generate_image_data_from_nxdetector - potential image datasets are now compared against scannables_shape(), this means scannables must be defined first. - changed No NXdetector found warning to info as not all scans contain this. - changed behaviour of populate() sof image_data is after scannables and generate_combined() is added, consistent with change to hdfmap_class.py - added call to generate_scannables to populate file_functions.py - removed "if not nxmap.scannables" and placed this check within NexusMap.populate tests - added additional tests for NXxas scan and 3D hysteresis scan on i10-1. All tests complete
Fixes for issue #16 eval_functions.py - added min_dim to is_shape(), allowing specification of minumum dataset shape hdfmap_class.py - Removed generate_combined() call from the various generate_scannables methods and instead put it in populate. - changed the behaviour of generate_scannables_from_group() so the scannable shape is now the shape of the smallest dataset in the group, rather than the first dataset, avoiding defining the shape as an image dataset. - change default detector_image name from 'image_data' to 'IMAGE' to stop conflits with 'image_data' group in scan files. nexus.py - changed behaviour of generate_image_data_from_nxdetector - potential image datasets are now compared against scannables_shape(), this means scannables must be defined first. - changed No NXdetector found warning to info as not all scans contain this. - changed behaviour of populate() sof image_data is after scannables and generate_combined() is added, consistent with change to hdfmap_class.py - added call to generate_scannables to populate file_functions.py - removed "if not nxmap.scannables" and placed this check within NexusMap.populate tests - added additional tests for NXxas scan and 3D hysteresis scan on i10-1. All tests complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for issue #16
eval_functions.py
hdfmap_class.py
nexus.py
file_functions.py
tests
All tests complete