Conversation
Potential fix for #18. Currently doesn't pass all tests as these need updating.
Added additional test file that includes h5py.SoftLink - KEK_PFdata.h5 Added tests in test_hdf_loader.py to check utility functions work correctly. Added utilities.md to docs. All tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow scannables from links
Fix for #18
Remove requirement on HdfMap.datasets to not be a h5py.SoftLink.
This hasn't required many changes and passes all the old file tests as Diamond files from GDA typically don't use h5py.SoftLink objects.