Merged
Conversation
Fix for issue #23 where axes and signal attributes are not named in scannables. This is evident in msmapper processed files where volume is present. hdfmap_class.py - change behaviour of generate_scannables_from_group() to set scannables to empty if there are less than two paths named. - changed first_last_scannables to correct error where names were not removed from the list. nexus.py - added values to generate_scannables_from_nxdata to add axes to scannables. - refactored generate_image_data_from_nxdetector to search NXdata if NXdetector not present. - added check in populate() to empty scannables if there are less scannables than dimensions (shape). test_files.json - added msmapper volume file to test All tests completed and passed.
Fix for #22 where specifying default_entry_only would give an infinite loop, caused by looping over re-populated entry list. nexus.py - populate() now loops over non-duplicated entries with default first. - generate_scannables_from_scan_fields_or_nxdata() now defaults to nxdata if scan_fields is empty. test_files.json - added xas_notebook file to test All tests completed and passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix scannables from volume file & fix default_entry error
Fix for #22 where specifying default_entry_only would give an infinite loop, caused by looping over re-populated entry list.
Fix for issue #23 where axes and signal attributes are not named in scannables. This is evident in msmapper processed files where volume is present.
hdfmap_class.py
nexus.py
test_files.json