Merged
Conversation
Option to turn on and off local data in hdfmap. Fix for #33 eval_functions.py - Add option use_stored_data to prepare_expression_load_data() - populate data_namspace in generate_namespace(), don't populate defaults. - load data from file based on identifiers. Remove identifiers if they are in data_namespace and use_stored_data is true. - propagate option to eval and format_hdf hdfmap_class.py - propagate option to eval and format_hdf - add _use_local_data parameter - add use_local_data function test_many_files.py - add test to check that this works in both scenarios. tests - tests pass. - 2 problems, unrelated I think (windows PC): - test_hdf_compare. Expected 26879, got 26967 - test_create_metadata_list. Expected 5280, got 5342
fixed tests so they don't compare absolute filepaths, which can change.
fixed tests so they don't compare absolute filepaths, which can change.
DanPorter
deleted the
33-hdfmapeval-loading-data-from-previous-file-not-current-one
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Option to turn on and off local data loading in hdfmap.
eval_functions.py
hdfmap_class.py
test_many_files.py
tests