Skip to content

adding a barrier after output folder creation#719

Merged
dkazanc merged 3 commits into
mainfrom
race_on_folder
May 20, 2026
Merged

adding a barrier after output folder creation#719
dkazanc merged 3 commits into
mainfrom
race_on_folder

Conversation

@dkazanc
Copy link
Copy Markdown
Collaborator

@dkazanc dkazanc commented May 19, 2026

Fixes the issue of not having the output folder created for other ranks than 0.
I went the global_comm.Barrier() way as at this point in the run there shouldn't be much of racing going on and we're not loosing time on synchronisation? It fixes the problem in Jenkins tests and pipelines run.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • I have added the user-release-note label in order to include this PR in the "Notable
    Changes for Users" section in release notes

@dkazanc dkazanc requested a review from yousefmoazzam May 19, 2026 14:54
Copy link
Copy Markdown
Collaborator

@yousefmoazzam yousefmoazzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the team meeting, I think that adding a barrier is the correct way to resolve the race condition of the non-zero rank processes seeing the YAML file at all, or seeing the YAML file in the correct state.

Just needs the linting fixed and this is good to go, thanks! 🙂

@dkazanc dkazanc merged commit bab2371 into main May 20, 2026
3 checks passed
@dkazanc dkazanc deleted the race_on_folder branch May 20, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants