Skip to content

Nl/testing#6

Merged
NatLeung96 merged 5 commits into
mainfrom
nl/testing
Apr 28, 2026
Merged

Nl/testing#6
NatLeung96 merged 5 commits into
mainfrom
nl/testing

Conversation

@NatLeung96
Copy link
Copy Markdown
Collaborator

Part of my PDR objectives was to learn how to use pytest and to write tests for the imaging_toolbox.

Here is my attempt to do so.

I've also made small fixes, that include:

  • Adding a return type to the phase_ramp_removal function definition
  • Changing the default values for x_range and y_range in the crop_data and normalise_data from (0, -1) to (None, None)

For the latter point, providing no values should suggest no cropping but the original implementation removed the last row and column

@NatLeung96 NatLeung96 requested a review from daurer April 27, 2026 12:40
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.62%. Comparing base (38e477d) to head (e2bd420).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #6       +/-   ##
===========================================
+ Coverage   13.18%   73.62%   +60.43%     
===========================================
  Files           8        8               
  Lines          91       91               
===========================================
+ Hits           12       67       +55     
+ Misses         79       24       -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@daurer daurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, nice and clean! In a new PR maybe add github actions that run the tests on push to pull requests?

@NatLeung96 NatLeung96 merged commit bfd9b6a into main Apr 28, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants