Skip to content

Fix making aithre devices#1613

Merged
DominicOram merged 4 commits intomainfrom
move_aithre_to_new_device_factory
Feb 6, 2026
Merged

Fix making aithre devices#1613
DominicOram merged 4 commits intomainfrom
move_aithre_to_new_device_factory

Conversation

@DominicOram
Copy link
Contributor

Part of DiamondLightSource/dodal#1902

Link to dodal PR (if required): DiamondLightSource/dodal#1903

Instructions to reviewer on how to test:

  1. Confirm tests still pass against linked dodal

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@DominicOram DominicOram requested a review from a team as a code owner February 5, 2026 18:54
@DominicOram DominicOram added the dev experience Changes relating to developer experience label Feb 5, 2026
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.83%. Comparing base (7a4ce56) to head (d87b9c3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1613   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         152      152           
  Lines        8614     8614           
=======================================
  Hits         7997     7997           
  Misses        617      617           
Components Coverage Δ
i24 SSX 78.60% <ø> (ø)
hyperion 98.21% <ø> (ø)
other 98.32% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jacob720 jacob720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests all pass against dodal main. Just need to change pyproject.toml back

Co-authored-by: Jacob Williamson <jacob.williamson@diamond.ac.uk>
@DominicOram DominicOram enabled auto-merge (squash) February 6, 2026 12:11
@DominicOram DominicOram merged commit 072fcc6 into main Feb 6, 2026
19 of 22 checks passed
@DominicOram DominicOram deleted the move_aithre_to_new_device_factory branch February 6, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev experience Changes relating to developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants