221 Document gridscan coordinate systems#715
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #715 +/- ##
=======================================
Coverage 86.89% 86.89%
=======================================
Files 102 102
Lines 6908 6908
=======================================
Hits 6003 6003
Misses 905 905
|
4 tasks
olliesilvester
approved these changes
Dec 16, 2024
Contributor
olliesilvester
left a comment
There was a problem hiding this comment.
Thanks! I think this part of the code is always going to be confusing, but it's much more understandable after your changes
Comment on lines
294
to
297
| centre_of_mass_mm=xray_centre, | ||
| bounding_box_mm=( |
Contributor
There was a problem hiding this comment.
As discussed the entire logic here is quite hard to explain via comments, but I think this helps to explain the 0.5
Suggested change
| centre_of_mass_mm=xray_centre, | |
| bounding_box_mm=( | |
| # Bounding box coordinates give position of the centre of the box, subtract half a box size to get the start of the box | |
| bounding_box_mm=( |
Contributor
There was a problem hiding this comment.
Whoops, didn't mean to delete line 294 in this suggestion
8672fc6 to
631e3d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #221 and improves documentation about the reporting of the Zocalo Results
See also DiamondLightSource/dodal#958
It also fixes an issue where the bounding box returned in the
XRayCentreResultis off by 0.5 of a grid-box, however I don't think this impacts anything as this attribute isn't used yet.