Merged
Conversation
rtuck99
requested changes
Apr 23, 2025
rtuck99
left a comment
rtuck99
left a comment
There was a problem hiding this comment.
Needs rebasing/retargeting against another branch so that the unrelated changes do not appear in the diff
Contributor
Author
|
Merged everything else in main and rebased - now the diff is much more sensible |
rtuck99
reviewed
Apr 23, 2025
| /** Custom component for a dropdown selection which runs a plan unpon every change event | ||
| * For now to be used for backlight and zoom control | ||
| */ | ||
| export function SelectAndRunPlan(props: SelectionProps) { |
There was a problem hiding this comment.
Perhaps this can be renamed? - this sounds like a function when in reality it's a component.
Something like PlanBasedSelector ?
rtuck99
approved these changes
Apr 23, 2025
rtuck99
left a comment
rtuck99
left a comment
There was a problem hiding this comment.
Approved - minor comment regarding naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9