Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
+ Coverage 42.97% 43.00% +0.02%
==========================================
Files 45 45
Lines 3881 3883 +2
Branches 748 748
==========================================
+ Hits 1668 1670 +2
Misses 2089 2089
Partials 124 124 ☔ View full report in Codecov by Sentry. |
noemifrisina
approved these changes
Feb 15, 2024
Collaborator
noemifrisina
left a comment
noemifrisina
left a comment
There was a problem hiding this comment.
Nit: having both x_pixels and x_pixels_in_detector - and their y equivalent - seems a bit redundant. As these are NXCollection non-standard fields (which shouldn't be used anywhere else) we could just replace them...
Up to you, I'm okay with either solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186
Adds these extra fields because AutoPROC wants them