Merged
Conversation
Contributor
d-perl
commented
Apr 11, 2024
d-perl
commented
- update pre-commit black, run it on everything, update ruff invocation
- rename modules according to python conventions
noemifrisina
requested changes
Apr 19, 2024
Collaborator
noemifrisina
left a comment
noemifrisina
left a comment
There was a problem hiding this comment.
It looks fine, been in need of tidying up for awhile so thank you.
Only a small nit: I think it would be nicer to have NXclass_writers.py and NXmx_writer.py instead of nx_class_writers.py and nx_mx_writer.py to keep it consistent with the base class ("NXclass") and appication definition ("NXmx") naming in the nexus format
Collaborator
|
Forgot to add, the API docs will need to be fixed too. While the docs build finishes because there are no major failures, the pages will look broken (ie. not show anything) because they're still pointing to the old filenames. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.